Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-3053 Improve error reporting and logging
  3. MYFACES-3198

Unify exception handling from render_response component.encodeAll

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Won't Fix
    • None
    • None
    • General
    • None
    • myfaces core trunk

    Description

      Myfaces PartialViewContextImpl.PhaseAwareVisitCallback.processRenderComponent(UIComponent) catches only IOExpcetion and nothing else.

      I've checked Mojarra and RichFaces (they have own PartialViewContextImpl) and both those implementations catch all exception; that isolates rendering of a component (and it children) - in case of exception, rest of component tree can still be rendered.

      Similar concept of isolating execution for one component can be seen in UIInput.updateModel - problem in one component does not have influence on other components in tree. Maybe we should check all code for this symmetry.

      previous is valid for partial lifecycle. For full lifecycle, rendering begins with UIViewRoot.encodeAll .

      Also catched exception should not be logged, but queued with ExceptionQueuedEvent.

      Attachments

        Activity

          People

            Unassigned Unassigned
            markoc50 Martin Kočí
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: