[MYFACES-3136] [perf] review UIComponentBase.getRendererType

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.0-SNAPSHOT
• Fix Version/s: 2.0.13, 2.1.7
• Component/s: General
• Environment: myfaces core trunk
• Assignee: Leonardo Uribe
• Reporter: Martin Kočí
• Created: 11/May/11 20:02
• Updated: 03/Apr/12 18:39
• Resolved: 06/Mar/12 17:33

Description

1) method UIComponentBase.getRendererType is the most frequent, because all encodeBegin, getRendersChildren and encodeAll l try to locate renderer

2) getRendererType uses StateHelper.eval - but can be renderType ValueExpression? If not, change StateHelper.eval to StateHelper.get

3) should rendererType even be part of state saving? Each component I've ever seen has setRendererType("com.foo.renderer") in constructor and/or VDL calls setRendererType() after calling Application.createComponent(): If rendererType is not part of state saving, replace StateHelper with attribute

4) Cache getRenderer(FacesContext context) result anyway (I'll create separate issue for this)

Issue Links

• is part of: MYFACES-3488 [perf] store facelets MARK_CREATED and rendererType at UIComponentBase level