Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-2944

Make those add*** methods public in WebXml

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0.2
    • 2.0.3
    • SPI
    • None

    Description

      In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
      Is it possible to make those methods public, I did not see it will break anyting.
      Thanks

      Attachments

        1. MYFACES-2944.patch
          5 kB
          Haihong Xu
        2. MYFACES-2944-core.patch
          0.8 kB
          Haihong Xu
        3. MYFACES-2944-core-2.patch
          31 kB
          Leonardo Uribe
        4. MYFACES-2944-shared.patch
          21 kB
          Haihong Xu
        5. MYFACES-2944-shared-2.patch
          46 kB
          Leonardo Uribe

        Issue Links

          incorporates

          Bug - A problem which impairs or prevents the functions of the product. MYFACES-1754 References to external entities not working with WebXmlParser

          • Major - Major loss of function.
          • Closed
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. MYFACES-2986 Provide an interface to override how to find spi interfaces

          • Major - Major loss of function.
          • Closed

          Activity

            People

              lu4242 Leonardo Uribe
              xuhaihong Haihong Xu
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: