[MYFACES-2854] Processing @ResourceDependency on each component instance takes too long

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.2-SNAPSHOT
• Fix Version/s: 2.0.2
• Component/s: General
• Environment: myfaces current trunk
• Assignee: Leonardo Uribe
• Reporter: Martin Kočí
• Created: 03/Aug/10 11:32
• Updated: 16/Sep/10 04:11
• Resolved: 05/Aug/10 20:52

Description

Consider custom renderer with @ResourceDependencies (and many @ResourceDependency here). If a view has 500 UIComponent with this custom renderer, ApplicationImpl._handleAnnotations process the same set of ResourceDependecies again and again.

With my test scenario, VDL.buildView takes therefore 750ms. After small modification in ApplicationImpl _handleAnnotations it takes only 70 ms.

The modification can be like:

Class<?> inspectedClass = inspected.getClass();

// Process annotation only if this is the first creation of component(renderer,validator, converter) of particular type in this request/response
if (! context.getAttributes().containsKey(inspectedClass.getName()))

{ _handleListenerForAnnotations(context, inspected, inspectedClass, component, isProduction); _handleResourceDependencyAnnotations(context, inspectedClass, component, isProduction); // Remeber here that this class and it's dependencies are in viewRoot.componentResources context.getAttributes().put(inspectedClass.getName(), Boolean.TRUE); }

;

But I'm not sure what specification says about this processing.