[MYFACES-2371] NullPointerException on UIComponentClassicTagBase.getViewComponentIds() fixed on branch 2.0.x but not on branch 1.2.x

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.7
• Fix Version/s: 1.2.8
• Assignee: Leonardo Uribe
• Reporter: Asuka Langley
• Created: 28/Sep/09 07:19
• Updated: 17/Nov/09 03:12
• Resolved: 03/Nov/09 20:44

Description

The problem occurs when the user wants to access to a .jsp page that includes a <f:subview> tag.

It seems to be a bug on UIComponentClassicTagBase.getViewComponentIds(). It was fixed on 2.0.x branch but not on 1.2.x in this way:

before:

private Map<String,Object> getViewComponentIds()
{
Map<String, Object> requestMap = _facesContext.getExternalContext().getRequestMap();
Map<String, Object> viewComponentIds;

if (_parent == null)

{ // top level _componentInstance viewComponentIds = new HashMap<String,Object>(); requestMap.put(VIEW_IDS, viewComponentIds); }

else

{ viewComponentIds = (Map<String, Object>) requestMap.get(VIEW_IDS); }

return viewComponentIds;
}

After:

private Map<String, Object> getViewComponentIds()
{
Map<String, Object> requestMap = _facesContext.getExternalContext().getRequestMap();
Map<String, Object> viewComponentIds;

if (_parent == null)

{ // top level _componentInstance viewComponentIds = new HashMap<String, Object>(); requestMap.put(VIEW_IDS, viewComponentIds); }

else
{
viewComponentIds = (Map<String, Object>)requestMap.get(VIEW_IDS);

// Check if null, this can happen if someone programatically tries to do an include of a
// JSP fragment. This code will prevent NullPointerException from happening in such cases.
if (viewComponentIds == null)

{ viewComponentIds = new HashMap<String, Object>(); requestMap.put(VIEW_IDS, viewComponentIds); }

}

return viewComponentIds;
}