[MYFACES-1845] Only date is returned wihen both dateStyle and timeStyle are set without specifying type

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.2
• Fix Version/s: 1.2.3
• Environment: MyFaces 1.2.2
• Assignee: Leonardo Uribe
• Reporter: Michael Concini
• Created: 28/Mar/08 13:39
• Updated: 07/May/08 23:32
• Resolved: 29/Mar/08 03:45

Description

Given the following snippet, MyFaces should be rendering both the date and time but only renders the date.

<h:outputText value="#

{MyBean.someTime}

">
<f:convertDateTime dateStyle="full" timeStyle="full" />
</h:outputText>

According to the spec, if type is not specified:
■ if dateStyle is set and timeStyle is not, type defaults to date
■ if timeStyle is set and dateStyle is not, type defaults to time
■ if both dateStyle and timeStyle are set, type defaults to both

The 1.2.2 implemtation always returns date. I believe the problem is in the getType method of javax.faces.convert.DateTimeConverter.

Currently, anytime _type is null, its returning TYPE_DATE.
return _type != null ? _type : TYPE_DATE;

What might better comply with the spec would be to do something like this:
if(_type == null){
if(_dateStyle != null && _timeStyle != null)

{ return TYPE_BOTH; }

else if(_timeStyle != null)

{ return TYPE_TIME; }

else

{ return TYPE_DATE; }

}
return _type;

I've tested this code locally and it does fix the above behavior.