[MYFACES-1825] duplicate ids not detected in JspStateManagerImpl.checkForDuplicateIds()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.5
• Fix Version/s: 1.2.3
• Assignee: Bernd Bohmann
• Reporter: Gastón Kleiman
• Created: 26/Feb/08 15:14
• Updated: 07/May/08 23:32
• Resolved: 22/Apr/08 06:57

Description

Some duplicate id are not detected in my MyFaces(1.1.5)/Facelets(1.1.12) based application.

I think there's a bug in MyFaces's detection of duplicate ids in JspStateManagerImpl.checkForDuplicateIds() :

this code seems to be wrong :
boolean namingContainer = component instanceof NamingContainer;
while (it.hasNext()) {
UIComponent kid = (UIComponent) it.next();
if (namingContainer)

{ checkForDuplicateIds(context, kid, new HashSet()); }
else { checkForDuplicateIds(context, kid, ids); }
}


It should be :
while (it.hasNext()) {
UIComponent kid = (UIComponent) it.next();
boolean namingContainer = kid instanceof NamingContainer;
if (namingContainer) { checkForDuplicateIds(context, kid, new HashSet()); }

else

{ checkForDuplicateIds(context, kid, ids); }

}