[MYFACES-1818] JavascriptUtils.encodeString does not properly translate '\' characters into "\\" (2) characters

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.5, 1.2.2
• Fix Version/s: 1.1.6
• Component/s: General
• Environment: Standard
• Assignee: Leonardo Uribe
• Reporter: Nicholas Hagen
• Created: 13/Feb/08 15:32
• Updated: 12/Aug/08 21:03
• Resolved: 08/Aug/08 16:09

Description

JavascriptUtils.encodeString does not properly translate a single '\' backslash char into two "
" backslash characters in order to properly escape the Javascript string. The fix should be:

public static String encodeString(String string)
{
if (string == null)

{ return ""; }

StringBuffer sb = null; //create later on demand
String app;
char c;
for (int i = 0; i < string.length (); ++i)
{
app = null;
c = string.charAt;
switch (c)

{ case '\\' : app = "\\\\"; break; // NJH - Use double backslash as output for single backslash rather than single backslash for single backslash case '"' : app = "\\\""; break; case '\'' : app = "\\'"; break; case '\n' : app = "\\n"; break; case '\r' : app = "\\r"; break; }

if (app != null)
{
if (sb == null)

{ sb = new StringBuffer(string.substring(0, i)); }

sb.append(app);
} else {
if (sb != null)

{ sb.append(c); }

}
}

if (sb == null)

{ return string; }

else

{ return sb.toString(); }

}