MyFaces Core
  1. MyFaces Core
  2. MYFACES-1688

Highlighting of component on error page

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.1.6
    • Fix Version/s: 1.1.6
    • Component/s: General
    • Labels:
      None

      Description

      The patch just adds highlighting of the component that produced the error in the component tree

      1. sample-error.html
        22 kB
        Sorin Silaghi
      2. error_handling-02-08.patch
        7 kB
        Sorin Silaghi

        Activity

        Sorin Silaghi created issue -
        Sorin Silaghi made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Sorin Silaghi made changes -
        Attachment error_component_highlighting.patch [ 12362697 ]
        Hide
        Martin Marinschek added a comment -

        Hi Sorin,

        this is not enough, sorry. You'll need to go down the component tree and compare ids one by one to find to the correct component. There can be 10 components with the same id on a page in JSF - as an ID is only unique per naming container.

        Additionally, I asked you to print the last exception in the stacktrace on top additionally to the first exception - so first, the message of the top exception, second the message of the bottom exception, then the full stacktrace.

        regards,

        Martin

        Show
        Martin Marinschek added a comment - Hi Sorin, this is not enough, sorry. You'll need to go down the component tree and compare ids one by one to find to the correct component. There can be 10 components with the same id on a page in JSF - as an ID is only unique per naming container. Additionally, I asked you to print the last exception in the stacktrace on top additionally to the first exception - so first, the message of the top exception, second the message of the bottom exception, then the full stacktrace. regards, Martin
        Hide
        Sorin Silaghi added a comment -

        new and improved

        Show
        Sorin Silaghi added a comment - new and improved
        Sorin Silaghi made changes -
        Attachment error_highlighting.patch [ 12362776 ]
        Hide
        Sorin Silaghi added a comment -

        this is how the result looks

        Show
        Sorin Silaghi added a comment - this is how the result looks
        Sorin Silaghi made changes -
        Attachment sample-error.html [ 12362777 ]
        Sorin Silaghi made changes -
        Attachment error_component_highlighting.patch [ 12362697 ]
        Martin Marinschek made changes -
        Comment [ Brilliant! I really love the results, plus played around a bit more - I'm using less static methods now (we could still clean this up a bit more, whenever someone gets time, plus also think about when/where synchronization might be necessary), and I also made sure that beans which are not there anymore are actually removed from session and application scope.

        In any case, good work, Sorin - I love the effect for development - it will give us all a productivity boost.

        regards,

        Martin ]
        Hide
        Martin Marinschek added a comment -

        Hi Sorin,

        very good - I like both the algorithm you used, and the outcome. Nice work!

        Only thing - I can't apply the patch, as the file does seem to be out of date. Can you please recreate the patches?

        Thanks,

        regards,

        Martin

        Show
        Martin Marinschek added a comment - Hi Sorin, very good - I like both the algorithm you used, and the outcome. Nice work! Only thing - I can't apply the patch, as the file does seem to be out of date. Can you please recreate the patches? Thanks, regards, Martin
        Sorin Silaghi made changes -
        Attachment error_handling-02-08.patch [ 12363026 ]
        Martin Marinschek made changes -
        Attachment error_highlighting.patch [ 12362776 ]
        Martin Marinschek made changes -
        Assignee Martin Marinschek [ mmarinschek ]
        Priority Trivial [ 5 ] Critical [ 2 ]
        Hide
        Martin Marinschek added a comment -

        Thanks Sorin, excellent addition to MyFaces.

        regards,

        Martin

        Show
        Martin Marinschek added a comment - Thanks Sorin, excellent addition to MyFaces. regards, Martin
        Martin Marinschek made changes -
        Fix Version/s  1.1.6-SNAPSHOT [ 12312311 ]
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Leonardo Uribe made changes -
        Fix Version/s 1.1.6 [ 12312312 ]
        Fix Version/s  1.1.6-SNAPSHOT [ 12312311 ]
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        31s 1 Sorin Silaghi 27/Jul/07 20:44
        Patch Available Patch Available Resolved Resolved
        5d 12h 10m 1 Martin Marinschek 02/Aug/07 08:54
        Resolved Resolved Closed Closed
        380d 16h 49m 1 Leonardo Uribe 17/Aug/08 01:43

          People

          • Assignee:
            Martin Marinschek
            Reporter:
            Sorin Silaghi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development