[MYFACES-152] ResponseWriter.endDocument() abuse breaks ADF Faces

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0.9m9
• Fix Version/s: 1.1.1
• Component/s: General
• Assignee: Bruno Aranda
• Reporter: Adam Winer
• Created: 30/Mar/05 08:59
• Updated: 03/Aug/10 22:43
• Resolved: 03/Aug/10 22:43

Description

I've been shown some problems lately with MyFaces 1.0.9 and ADF Faces.
The problems specifically trace to MyFaces's use of
ResponseWriter.endDocument() to output Javascript. Since ADF Faces
runs with its own RenderKit (and therefore its own ResponseWriter),
this Javascript is getting dropped and not written.

I'd recommend (both as JSF EG guy and ADF Faces guy) that this MyFaces
code be moved out of ResponseWriter.endDocument(). Specifically:

• ResponseWriter.endDocument() is not guaranteed to be called before
  the close of or even the close of , and therefore this
  script cannot be safely output at this point. It's quite likely that
  changes in JSF 1.2 will essentially guarantee that endDocument() is
  not called until the close of all output.
• This is not really the intent of ResponseWriter.endDocument(). In
  HTML, it should be a no-op. It's there for more bizarre scenarios
  like a ResponseWriter outputting a SOAP envelope around a response.
• It's breaking ADF Faces.

A significantly cleaner way to output needed Javascript is to add it
as needed from the Renderers that require it (using a request-scoped
attribute to track if its been added already).

Issue Links

• is duplicated by: MYFACES-527 AutoScroll script/function should be rendered within head or body in html