[MYFACES-1353] HtmlResponseWriterImpl - Prematurely Closes HTML Elements

• Type: Wish
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.5-SNAPSHOT
• Fix Version/s: 2.0.1
• Component/s: General
• Environment: Facelets, JBoss Seam
• Assignee: Leonardo Uribe
• Reporter: Jacob John Hookom
• Created: 05/Jul/06 11:47
• Updated: 15/Jul/10 19:45
• Resolved: 10/Jul/10 22:25

Description

http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlResponseWriterImpl.java?view=markup

Sometimes ResponseWriters are used to supplement other markups and in JBoss Seam's Blog example, we provide RSS feeds:

he following facelets template:
>>
>> <link>foo</link>
>>
>> generates:
>>
>> <link/>foo

This is driven by the static set 's_emptyHtmlElements' where the closeIfNecessary() closes elements before they have a chance to be closed by the user of the ResponseWriter. The logic should be if the endElement is written and there's no body, then use that specialized set to determine if the element should be written as closed or not.

I'm not sure if the logic was setup to correct issues with errant Renderers, but correcting HTML markup should only be handling cases where a closed element will not work (span, div, script, etc)--- not the other way around.