Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-1157

EvaluationException gets swallowed in ValueBindingImpl and UIInput

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.1.1, 1.1.2-SNAPSHOT
    • None
    • General
    • None
    • all

    Description

      During model update, when an Exception is thrown in the setValue method of the PropertyResolverImpl, it is wrapped in an EvaluationException, which is then caught in the ValueBindingImpl, and again wrapped in another EvaluationException, which is finally caught in the UIInput, where a generic error FacesMessage is rendered to the browser. This could be cleaner, and differs from the way it is done in the Sun RI. The Sun RI does the following:

      1. Exception is caught by PropertyResolverImpl, wrapped in an EvaluationException, and thrown again
      2. ValueBindingImpl catches the EvaluationException and rethrows it unchanged
      3. UIInput catches the EvaluationException and creates an error FacesMessage containing the EvaluationException.getMessage() if it's not null, otherwise a generic error message.

      Attachments

        1. evaluation-api.patch
          2 kB
          Jurgen Lust
        2. evaluation-impl.patch
          0.7 kB
          Jurgen Lust

        Issue Links

          Activity

            People

              jlust Jurgen Lust
              jlust Jurgen Lust
              Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: