[MWRAPPER-90] Use arrays to preserve potential whitespace in arguments

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: Maven Wrapper Scripts
• Assignee: Unassigned
• Reporter: Benjamin Marwell
• Created: 09/Jan/23 20:22
• Updated: 09/Jan/23 20:40

Description

The bash scripts call mvn using:

# shellcheck disable=SC2086 # safe args
exec "$JAVACMD" \
$MAVEN_OPTS \
$MAVEN_DEBUG_OPTS \
-classpath "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.jar" \
"-Dmaven.multiModuleProjectDirectory=${MAVEN_PROJECTBASEDIR}" \
${WRAPPER_LAUNCHER} $MAVEN_CONFIG "$@"

However, this might mangle parameters containing spaces into multiple parameters. It would be only safe when using arrays and use quotes, e.g. "${MAVEN_OPTS[@]}". Same for the others. This would also allow us to disable the shellcheck check.