[MWRAPPER-67] mvnw script does not download jar if used in git bash in windows

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.1.1
• Fix Version/s: 3.2.0
• Component/s: Maven Wrapper Scripts
• Assignee: Slawomir Jaranowski
• Reporter: Jeremy Landis
• Created: 17/May/22 17:26
• Updated: 22/Feb/23 22:00
• Resolved: 22/Feb/23 22:00

Description

Usage of git bash will not download the maven wrapper jar along with curl (probably others) due to having windows line endings in the URL (trailing).  To ensure that is not the case, make sure to strip invalid line endings out before usage.

Use case, ./mvnw in powershell will use mvnw.cmd and has no issues downloading.  If user does same in git bash, it will fail with invalid URL error with curl.  Using ./mvnw.cmd there will work but not natural usage.  To ensure this simply just works for full support, trim out invalid line feeds.

note: This only affected the download.  It worked otherwise.

Issue Links

• links to: GitHub Pull Request #44