[MWRAPPER-139] Shell scripts break on LF in config for Windows

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.1
• Fix Version/s: 3.3.2
• Component/s: Maven Wrapper Scripts
• Flags: Patch, Important
• Assignee: Tamas Cservenak
• Reporter: Ashley Scopes
• Created: 12/May/24 11:18
• Updated: 21/May/24 13:00
• Resolved: 21/May/24 13:00

Description

Today, I updated the Maven Wrapper in a project I have on GitHub by running `./mvnw wrapper:wrapper`, and then pushed it to GitHub.

It appears that upon doing this, the bash scripts no longer work due to how newlines are being interpreted in the maven-wrapper.properties file.

+ ./mvnw --version
distributionUrl is not valid, must match *-bin.zip or maven-mvnd-*.zip, but found 'https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.6/apache-maven-3.9.6-bin.zip
'

This appears to just affect when running on GitHub actions with a Windows runner and the `bash` shell.

I will see if I can find the issue and raise a fix in an MR

Issue Links

• fixes: MWRAPPER-136 maven-wrapper.properties created with Windows line breaks which mvnw can't handle
• fixes: MWRAPPER-137 Can't match distributionUrl when using MINGW64
• links to: GitHub Pull Request #139