[MWRAPPER-114] Maven wrapper relative distributionUrl does not work on Windows

• Type: Bug
• Status: Open
• Priority: Normal
• Resolution: Unresolved
• Affects Version/s: 3.2.0
• Component/s: Maven Wrapper Jar
• Environment: Windows
• Assignee: Unassigned
• Reporter: Edward Woolhouse
• Created: 10/Aug/23 19:22
• Updated: 18/Sep/24 08:58

Description

If Maven Wrapper is used with a relative distributionUrl on Windows then an error message indicating invalid path characters is shown.

 

# Directory structure 
./mvnw
./mvnw.cmd
./.mvn/wrapper/maven-wrapper.jar
./.mvn/wrapper/maven-wrapper.properties
...

# maven-wrapper.properties
distributionUrl=apache-maven-3.8.8-bin.zip
wrapperUrl=maven-wrapper.jar

When run

./mvnw

...
java.nio.file.InvalidPathException: Illegal char <:> at index 2: /C:/some-path/apache-maven-3.8.8.zip 

This is caused by PathAssembler.java:getBaseName unnecessarilly stringifying the distibution URL. The fix is as follows

    private String getBaseName(URI distUrl) {
-       return Paths.get(distUrl.getPath()).getFileName().toString();
+       return Paths.get(distUrl).getFileName().toString();
    }

 

Issue Links

• links to: GitHub Pull Request #107