[MTOMCAT-226] Wasted work in AbstractCatalinaMojo#getManager()

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: backlog
• Assignee: Unassigned
• Reporter: Sebb
• Created: 11/Jun/13 22:53
• Updated: 01/Nov/13 05:51

Description

AbstractCatalinaMojo#getManager() fetches AuthenticationInfo for the server from the wagon and only then checks if the user/pass has been provided on the command-line. At which point the AuthenticationInfo is not actually needed, so the work was wasted.

The code should check for the command line override first, and only fetch the AuthenticationInfo if necessary.