Apache Tomcat Maven Plugin
  1. Apache Tomcat Maven Plugin
  2. MTOMCAT-198

Fix base classes for redeploy and redeploy-only goals

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1
    • Component/s: tomcat7
    • Labels:
      None

      Description

      Hi, I've noticed some problems with certain of the goals:

      1.) The redeploy-only goal is incorrectly spelled "redeplo-goal"
      2.) I believe the redeploy MOJO should extend the DeployMojo, not the AbstractDeployWarMojo, as it by definition is the DeployMojo with the isUpdate() set to true.
      3.) The redeploy-only mojo should extend the DeployOnlyMojo (same reason).
      4.) The redeploy-only mojo incorrectly has "@Execute( phase = LifecyclePhase.PACKAGE )" defined.

        Activity

        Hide
        Olivier Lamy (*$^¨%`£) added a comment -
        Show
        Olivier Lamy (*$^¨%`£) added a comment - fixed http://svn.apache.org/r1430970 Thanks !
        Hide
        Hudson added a comment -

        Integrated in TomcatMavenPlugin-mvn3.x #227 (See https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/227/)
        MTOMCAT-198 Fix base classes for redeploy and redeploy-only goals (Revision 1430970)

        Result = SUCCESS
        olamy : http://svn.apache.org/viewvc/?view=rev&rev=1430970
        Files :

        • /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/deploy/RedeployMojo.java
        • /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/deploy/RedeployOnlyMojo.java
        Show
        Hudson added a comment - Integrated in TomcatMavenPlugin-mvn3.x #227 (See https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/227/ ) MTOMCAT-198 Fix base classes for redeploy and redeploy-only goals (Revision 1430970) Result = SUCCESS olamy : http://svn.apache.org/viewvc/?view=rev&rev=1430970 Files : /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/deploy/RedeployMojo.java /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/deploy/RedeployOnlyMojo.java

          People

          • Assignee:
            Olivier Lamy (*$^¨%`£)
            Reporter:
            Glen Mazza
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development