Apache Tomcat Maven Plugin
  1. Apache Tomcat Maven Plugin
  2. MTOMCAT-185

change phase for tomcat6/7:run to process-classes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.1
    • Component/s: tomcat7
    • Labels:

      Description

      Hello,

      I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere.

      We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat.

      After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with <goal>run</goal> and in this mojo there i found <executePhase>compile</executePhase>. I think that the execution phase should be set to process-classes phase and not compile phase.

      My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar.

      I checked the sources and to me it seams that the phase should be set here:
      http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup

      The execution phase is set there to be compile (curretnly line 60)

        Activity

        Hide
        Olivier Lamy (*$^¨%`£) added a comment - - edited

        Yup I agree it's a better phase especially for your use case
        So I change that.
        NOTE you can test snapshot following instructions from here: http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/snapshot-test.html

        Show
        Olivier Lamy (*$^¨%`£) added a comment - - edited Yup I agree it's a better phase especially for your use case So I change that. NOTE you can test snapshot following instructions from here: http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/snapshot-test.html
        Hide
        Jiri Peinlich added a comment -

        Thank you .

        Show
        Jiri Peinlich added a comment - Thank you .
        Hide
        Jiri Peinlich added a comment -

        I can confirm, that it is fixed in the snapshot. Thank you.

        Show
        Jiri Peinlich added a comment - I can confirm, that it is fixed in the snapshot. Thank you.
        Hide
        Hudson added a comment -

        Integrated in TomcatMavenPlugin-mvn3.x #219 (See https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/219/)
        MTOMCAT-185 change phase for tomcat6/7:run to process-classes (Revision 1409194)

        Result = SUCCESS
        olamy : http://svn.apache.org/viewvc/?view=rev&rev=1409194
        Files :

        • /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
        • /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java
        Show
        Hudson added a comment - Integrated in TomcatMavenPlugin-mvn3.x #219 (See https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/219/ ) MTOMCAT-185 change phase for tomcat6/7:run to process-classes (Revision 1409194) Result = SUCCESS olamy : http://svn.apache.org/viewvc/?view=rev&rev=1409194 Files : /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        no idea why the issue was reopened.

        Show
        Olivier Lamy (*$^¨%`£) added a comment - no idea why the issue was reopened.

          People

          • Assignee:
            Olivier Lamy (*$^¨%`£)
            Reporter:
            Jiri Peinlich
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development