Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-beta-1
    • Fix Version/s: 2.1
    • Component/s: tomcat7
    • Labels:
      None

      Description

      in tomcat6-m-p there is a undeploy goal but no more in tomcat7 plugin.

      I understand that undeploy function is now no more accessible via the /manager/html but only via the /manager/text.

      I see one problem to fix this :

      • The manager url (via the AbstractCatalinaMojo#url field) is common to all mojo and by default is setted to /manager/html.

      Should we use instead two fields :

      • one for tomcat manager url (http://localhost:8080/manager) (common to all mojo)
      • one for type of manager to use html in some mojo case, text in other cases ?

        Activity

        Hide
        Hudson added a comment -

        Integrated in TomcatMavenPlugin-mvn3.x #227 (See https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/227/)
        MTOMCAT-163 No tomcat7 undeploy goal
        Submitted by Tony Chemit. (Revision 1430030)

        Result = SUCCESS
        olamy : http://svn.apache.org/viewvc/?view=rev&rev=1430030
        Files :

        • /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/deploy/UndeployMojo.java
        Show
        Hudson added a comment - Integrated in TomcatMavenPlugin-mvn3.x #227 (See https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/227/ ) MTOMCAT-163 No tomcat7 undeploy goal Submitted by Tony Chemit. (Revision 1430030) Result = SUCCESS olamy : http://svn.apache.org/viewvc/?view=rev&rev=1430030 Files : /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/deploy/UndeployMojo.java
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        applied.
        Thanks !

        Show
        Olivier Lamy (*$^¨%`£) added a comment - applied. Thanks !
        Hide
        Glen Mazza added a comment -

        I think the default URL for the Tomcat 7 plugin should be /manager/text for everything, allowing the mvn tomcat7:undeploy to be brought back. For the Codehaus Maven plugin, it was necessary for me to switch from http://localhost:8080/manager for Tomcat 6 to http://localhost:8080/manager/text for Tomcat7 (See here: http://www.jroller.com/gmazza/entry/web_service_tutorial#WFstep3-war), along with different permissions in the tomcat-users.xml file (http://www.jroller.com/gmazza/entry/web_service_tutorial#maventomcat).

        From the Tomcat 7 documentation, bottom of this section: http://tomcat.apache.org/tomcat-7.0-doc/manager-howto.html#Introduction it's clear the /manager/html is just for the graphical webapp while the /manager/text is for scripting (including presumably the Maven Tomcat7 plugin), as further shown here: http://tomcat.apache.org/tomcat-7.0-doc/manager-howto.html#Supported_Manager_Commands .

        Show
        Glen Mazza added a comment - I think the default URL for the Tomcat 7 plugin should be /manager/text for everything, allowing the mvn tomcat7:undeploy to be brought back. For the Codehaus Maven plugin, it was necessary for me to switch from http://localhost:8080/manager for Tomcat 6 to http://localhost:8080/manager/text for Tomcat7 (See here: http://www.jroller.com/gmazza/entry/web_service_tutorial#WFstep3-war ), along with different permissions in the tomcat-users.xml file ( http://www.jroller.com/gmazza/entry/web_service_tutorial#maventomcat ). From the Tomcat 7 documentation, bottom of this section: http://tomcat.apache.org/tomcat-7.0-doc/manager-howto.html#Introduction it's clear the /manager/html is just for the graphical webapp while the /manager/text is for scripting (including presumably the Maven Tomcat7 plugin), as further shown here: http://tomcat.apache.org/tomcat-7.0-doc/manager-howto.html#Supported_Manager_Commands .
        Hide
        Tony Chemit added a comment -

        Patch with undeploy mojo for tomcat7-m-p + usage of /manager/text in AbstractCatalinaMojo (not the best way to do it FMHO).

        Show
        Tony Chemit added a comment - Patch with undeploy mojo for tomcat7-m-p + usage of /manager/text in AbstractCatalinaMojo (not the best way to do it FMHO).

          People

          • Assignee:
            Olivier Lamy (*$^¨%`£)
            Reporter:
            Tony Chemit
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development