Apache Tomcat Maven Plugin
  1. Apache Tomcat Maven Plugin
  2. MTOMCAT-109

<protocol>org.apache.coyote.http11.Http11NioProtocol</protocol> not honoured

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-beta-1
    • Fix Version/s: 2.0-beta-1
    • Component/s: None
    • Labels:
      None

      Description

      Tomcat7Runner.java

      Line 146: Connector connector = new Connector( "HTTP/1.1" );

      Make it possible to use NIO connector, through <protocol> option so that connector is initialized using something like:
      Connector connector = new Connector( "org.apache.coyote.http11.Http11NioProtocol" );

        Activity

        Morten Haraldsen created issue -
        Hide
        Morten Haraldsen added a comment -

        This is effectively blocking usage of this plugin for application relying on Comet connections (Does not scale with blocking I/O)

        Show
        Morten Haraldsen added a comment - This is effectively blocking usage of this plugin for application relying on Comet connections (Does not scale with blocking I/O)
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        need a new parameter for that.

        Show
        Olivier Lamy (*$^¨%`£) added a comment - need a new parameter for that.
        Olivier Lamy (*$^¨%`£) made changes -
        Field Original Value New Value
        Assignee Olivier Lamy [ olamy ]
        Fix Version/s 2.0 [ 12317943 ]
        Affects Version/s 2.0 [ 12317943 ]
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        do you prefer something configurable tru cli when running your jar or something in the mojo which build the jar ? (perso I prefer 2) )

        Show
        Olivier Lamy (*$^¨%`£) added a comment - do you prefer something configurable tru cli when running your jar or something in the mojo which build the jar ? (perso I prefer 2) )
        Hide
        Morten Haraldsen added a comment -

        I think (at least for now) using a mojo option is perfectly fine

        Show
        Morten Haraldsen added a comment - I think (at least for now) using a mojo option is perfectly fine
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        finally both have been implemented
        a default value tru a mojo parameter (default HTTP/1.1).
        but there is now a new option when starting the jar: -httpProtocol
        feel free to test SNAPSHOT build and have fun

        Show
        Olivier Lamy (*$^¨%`£) added a comment - finally both have been implemented a default value tru a mojo parameter (default HTTP/1.1). but there is now a new option when starting the jar: -httpProtocol feel free to test SNAPSHOT build and have fun
        Olivier Lamy (*$^¨%`£) made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in TomcatMavenPlugin #74 (See https://builds.apache.org/job/TomcatMavenPlugin/74/)
        MTOMCAT-109 nio protocol is impossible to use with tomcat exec mojo.
        add an option in tomcat runner to override it tru cli
        -httpProtocol
        as it can be change on application start not only in the produced jar.
        MTOMCAT-109 nio protocol is impossible to use with tomcat exec mojo.

        olamy : http://svn.apache.org/viewvc/?view=rev&rev=1220675
        Files :

        • /tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java
        • /tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7RunnerCli.java

        olamy : http://svn.apache.org/viewvc/?view=rev&rev=1220674
        Files :

        • /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java
        • /tomcat/maven-plugin/trunk/tomcat7-war-runner/NOTES.TXT
        • /tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java
        Show
        Hudson added a comment - Integrated in TomcatMavenPlugin #74 (See https://builds.apache.org/job/TomcatMavenPlugin/74/ ) MTOMCAT-109 nio protocol is impossible to use with tomcat exec mojo. add an option in tomcat runner to override it tru cli -httpProtocol as it can be change on application start not only in the produced jar. MTOMCAT-109 nio protocol is impossible to use with tomcat exec mojo. olamy : http://svn.apache.org/viewvc/?view=rev&rev=1220675 Files : /tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java /tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7RunnerCli.java olamy : http://svn.apache.org/viewvc/?view=rev&rev=1220674 Files : /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java /tomcat/maven-plugin/trunk/tomcat7-war-runner/NOTES.TXT /tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java
        Hide
        Morten Haraldsen added a comment -

        Thank you!

        Show
        Morten Haraldsen added a comment - Thank you!

          People

          • Assignee:
            Olivier Lamy (*$^¨%`£)
            Reporter:
            Morten Haraldsen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development