[MSKINS-81] Decoration model body/footer not correctly implemented by site.vm

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: fluido-1.3.0, fluido-1.3.1
• Fix Version/s: fluido-1.4
• Component/s: Fluido Skin
• Assignee: Michael Osipov
• Reporter: Michael Osipov
• Created: 02/Mar/13 16:54
• Updated: 10/Feb/15 04:17
• Resolved: 25/Dec/14 14:15

Description

Documenation for /body/footer says:

If present, the contained text will be used instead of the generated copyright text.

The default skin does this correctly with:

<div id="footer">
      <div class="xright">
      #if($decoration.body.footer)
        $decoration.body.footer
      #else
        Copyright &#169;#copyright()All Rights Reserved.#publishDate( "bottom" $decoration.publishDate $decoration.version )
      #end
      </div>
      <div class="clear">
        <hr/>
      </div>

Unfortunately, this skin does not observe that and simply appends the content:

<div class="row">
          #if ( $decoration.custom.getChild( 'fluidoSkin' ) && $decoration.custom.getChild( 'fluidoSkin' ).getChild('copyrightStyle') )
            <p class="$decoration.custom.getChild( 'fluidoSkin' ).getChild('copyrightStyle').getValue()">Copyright &copy;#copyright()All Rights Reserved.#publishDate( "bottom" $decoration.publishDate $decoration.version )</p>
          #else
            <p class="span12">Copyright &copy;#copyright()All Rights Reserved.#publishDate( "bottom" $decoration.publishDate $decoration.version )</p>
          #end

        </div>

        #if ( $decoration.body.footer )
          #foreach( $item in $decoration.body.footer.getChildren() )
            #set ( $foot = $item.toString().trim() )
            #set ( $documentHeader = '<?xml version="1.0" encoding="UTF-8"?>' )
            #set ( $foot = $StringUtils.replace( $foot.toString(), $documentHeader, "" ) )
            ## Workaround for http://jira.codehaus.org/browse/MSITE-135
            ## Use StringUtils untill http://jira.codehaus.org/browse/DOXIASITETOOLS-67 is fixed
            ## #eval macro not supported yet, that is a silly turnaround to allow ASF projects adopt fluido
            $StringUtils.replace( $foot, '@project.name@', ${project.name} )
          #end
        #end

So, footer cannot be exchanged.

Issue Links

• duplicates: MSKINS-108 Impossible to override the copyright notice
• is related to: DOXIASITETOOLS-82 Decoration model body/footer type mismatch