[MSKINS-250] bannerLeft/Right have external link decoration when consisting only out of image

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: fluido-2.0.0-M10
• Fix Version/s: fluido-2.0.0
• Component/s: Fluido Skin
• Assignee: Michael Osipov
• Reporter: Konrad Windszus
• Created: 30/Aug/24 15:24
• Updated: 08/Sep/24 15:40
• Resolved: 08/Sep/24 15:40

Description

I have the following snippet in my site descriptor (v1.8)

<bannerLeft>
        <name>My Name</name>
        <src>someimage.png</src>
        <href>https://google.com/</href>
</bannerLeft>

with Fluido 1.12.0 this renders the image only, i.e.

<div id="banner">
          <div class="pull-left"><a href="https://google.com/" id="bannerLeft"><img src="someimage.png"  alt="My Name" style="" /></a></div>

With Fluido 2.0.0-M10 and Site Descriptor 2.0:

<bannerLeft href="https://google.com/">
        <image src="someimage.png" />
    </bannerLeft>

it renders as

<div id="bannerLeft"><h1><a href="https://google.com/" class="externalLink"><img class="imageLink" src="someimage.png" /></a></h1></div>

The class externalLink leads to an additional unwanted decorator next to the image.

Issue Links

• is caused by: MSKINS-170 Allow to show name as headline in addition to bannerLeft
• is caused by: MSKINS-237 Rework skin for new site model