Uploaded image for project: 'Maven Skins'
  1. Maven Skins
  2. MSKINS-194

Load GitHub ribbon with CSS only

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • fluido-1.11.0
    • fluido-1.11.1
    • Fluido Skin
    • None

    Description

      The GitHub ribbons are loaded from an AWS S3 bucket (https://github.com/apache/maven-fluido-skin/blob/171292d7f70b78c449d602da2414815cdb8e4ffd/src/main/resources/META-INF/maven/site-macros.vm#L666). To prevent exposing information about the site visitor, those images should be loaded locally. Also this is necessary to be compliant with https://privacy.apache.org/policies/privacy-policy-public.html.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            michael-o Michael Osipov
            kwin Konrad Windszus
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment