Uploaded image for project: 'Maven Skins'
  1. Maven Skins
  2. MSKINS-193

Remove third party JS for Google Site Search

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • fluido-1.11.0
    • fluido-1.11.1
    • Fluido Skin
    • None

    Description

      Currently the Google Search Feature relies on a JS loaded from Google (for skinning purposes): https://github.com/apache/maven-fluido-skin/blob/171292d7f70b78c449d602da2414815cdb8e4ffd/src/main/resources/META-INF/maven/site-macros.vm#L634. In order to be compatible with https://privacy.apache.org/policies/privacy-policy-public.html one should not load any resources from Google without explicit User consent.

      It should be possible to use the Google Site Search with just custom HTML and CSS without the need to load JS from Google.

      Obviously once the user submitted a search query, Google would get all data, but I guess consent can be assumed in that case.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            michael-o Michael Osipov
            kwin Konrad Windszus
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment