[MSITE-533] make site:stage a local file deploy

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2
• Fix Version/s: 2.3, 3.0
• Component/s: site:deploy, site:stage(-deploy)
• Assignee: Lukas Theussl
• Reporter: Lukas Theussl
• Created: 18/Dec/10 11:40
• Updated: 07/Apr/15 18:15
• Resolved: 18/Jan/11 04:26

Description

As I understand it, site:stage is supposed to be a local preview of site:deploy. However, the site construction is very different in both cases: site:stage changes the <url> pom element of each reactor project and generates the site directly at the final target (staging) location. Unfortunately, this suffers from a couple of bugs, in particular wrt relative links in multi-module builds, which is potentially confusing for users (and certain developers...) if they find that the staged site is different from the deployed site. site:deploy OTOH generates each site into its own target and then uses wagon to copy the single sites to the final destination.

I also don't see why SiteStageMojo extends SiteMojo, staging shouldn't have anything to do with site generation. IMO site:deploy, site:stage and site:stage-deploy should all do the same basic thing: take a pre-generated site directory and copy it to some target. The difference is only in the target location: site:deploy goes to distributionManagement.site.url, site:stage goes to stagingDirectory on the local file system, and site:stage-deploy goes to stagingSiteURL.

Since site:deploy supports a local file copy, I propose to replace site:stage by such a local deploy. This would make site:stage and deploy equivalent, reduce confusion and maintenance efforts and make site:stage a true preview per definition. Are there any arguments that speak against it?

Issue Links

• is depended upon by: MSITE-534 site:stage gives different links than site:deploy
• relates to: MSITE-357 staging should execute some phase of the lifecycle
• relates to: MSITE-479 stage-deploy re-run's all javadoc's for every module
• relates to: MSITE-534 site:stage gives different links than site:deploy
• relates to: MSITE-295 Make the distributionManagement.site.url configurable from the command line