[MSHARED-971] System environment variable are always added to maven-invoker

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: maven-invoker-3.3.0
• Component/s: maven-invoker, maven-shared-utils
• Assignee: Slawomir Jaranowski
• Reporter: Slawomir Jaranowski
• Created: 29/Dec/20 16:20
• Updated: 07/May/24 20:44
• Resolved: 07/May/24 20:44

Description

In org.apache.maven.shared.invoker.MavenCommandLineBuilder

https://github.com/apache/maven-invoker/blob/d58703dd592ba0bc6f0a09928d0cce90e4002af9/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java#L197-L242

we have code:

        if ( request.isShellEnvironmentInherited() )
        {
                cli.addSystemEnvironment();
         }

but in org.apache.maven.shared.utils.cli.Commandline we have:

 public String[] getEnvironmentVariables()
    {
        addSystemEnvironment();
       ...
     }

System environment variable are always added - it is inconsistent implementation.

Issue Links

• is blocked by: MSHARED-1014 Optionally inherit system environment variables by Commandline
• is related to: MSHARED-969 Environment variable with null value
• links to: GitHub Pull Request #79