Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
-
None
Description
The trim parameter in buildDom methods in Xpp3DomBuilder is based on a serious misunderstanding of how the characters method in SAX works. As currently written, trim can potentially remove all whitespace in text content from a document. A little more commonly, it will randomly remove or not remove whitespace depending on how the SAX parser chooses to split text nodes when it reports them.
It might be possible to implement this correctly at the cost of a lot of code complexity if anyone is using this. More easily, we could make the parameter a no-op and never trim.