[MSHARED-910] Redundant option failOnException

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: maven-script-interpreter-1.3
• Component/s: maven-script-interpreter
• Assignee: Sylwester Lachiewicz
• Reporter: Slawomir Jaranowski
• Created: 31/May/20 23:03
• Updated: 23/Jul/20 19:45
• Resolved: 22/Jul/20 22:17

Description

In code of ScriptRunner we have:

if ( failOnException )
{
    throw new RunFailureException( "The " + scriptDescription + " did not succeed. " + msg, stage );
}
else
{
    throw new RunErrorException( "The " + scriptDescription + " did not succeed. " + msg, stage, t );
}
 

This cause to only throw different exception, but in client code we should catch exception regardless of this option.

I think that this complicate code of this class and code on client with process many exceptions.

My proposition:

• remove option failOnException
• remove exceptions: RunFailureException and RunErrorException
• throw by methods run, executeRun - ScriptEvaluationException

I can do it - after your approval.

Issue Links

• links to: GitHub Pull Request #12
• links to: GitHub Pull Request #14