[MSHARED-884] Only overwrite filtered resources when contents differ

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: maven-filtering-3.2.0
• Component/s: maven-filtering
• Assignee: Olivier Lamy
• Reporter: Robert James Oxspring
• Created: 29/Apr/20 20:52
• Updated: 25/Jul/22 10:15
• Resolved: 17/Jul/20 12:48

Description

When filtering files with the MavenFileFilter.copyFile method, the destination file should only be overwritten if the contents have changed. Currently we unconditionally overwrite the contents in this situation, potentially leading to unnecessary downstream work. When the overwrite parameter is true then overwriting should overwrite as it does now.

Given a copyFile call
When an identical copyFile operation is performed
Then the destination file should remain unmodified

Given a copyFile call with overwrite set true
When an identical copyFile operation is performed
Then the destination file should be overwritten

The linked pull request meets these requirements by writing the filtered resource to a temporary file and then comparing the temporary contents to the content of a previously written target file. If the contents match then the temporary file is deleted, otherwise it's renamed over the top of the target file.

Issue Links

• breaks: MSHARED-1107 FileUtils.copyFile() fails with source file having lastModified = 0
• Dependency: MRESOURCES-258 Only overwrite filtered resources when contents differ
• links to: GitHub Pull Request #5
• links to: GitHub Pull Request #28