Uploaded image for project: 'Maven Shared Components'
  1. Maven Shared Components
  2. MSHARED-864

Refactor and simplify code

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      • In the classes Maven30DependencyResolver.java, Maven31DependencyResolver.java code can be cleaned up.
        • The code calls setDependencies( List<Dependency> dependencies ) of CollectRequest which allows to give null
      • Refactoring in Invoker.java
        • Remove not used methods.
        • Inlining only locally called methods.
        • Move the SuppressWarnings to the invoke methods only; Not in user code (outside of Invoker classes)
        • Make code comment requirements to code requirements (number of elements in argClasses ands args)
        • Using generics removes the need of type casts in user code (outside Invoker classes)
      • Simplify catching exceptions (
      • MavenArtifactDeployer interface is not needed to be public.
      • MavenDependencyCollector interface is not needed to be public.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            khmarbaise Karl Heinz Marbaise
            khmarbaise Karl Heinz Marbaise
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment