[MSHARED-749] Commandline does not thrown CommandLineException when uneven number of quotation marks used

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Done
• Affects Version/s: maven-shared-utils-3.2.1
• Fix Version/s: maven-shared-utils-3.3.3
• Assignee: Karl Heinz Marbaise
• Reporter: Kathryn Newbould
• Created: 27/Jul/18 08:31
• Updated: 29/Jul/18 12:35
• Resolved: 29/Jul/18 12:28

Description

The merged fix for MSHARED-416 did not fully fix the issue as the process does not return non-0 on failure (which is what the tests were based on).

As an example:

 

@Test
public void MSHARED_416 () throws Exception {
    Process p = new Commandline("\"Hi\" Friends\"").execute();
    Thread.sleep(1000);
    assertNotEquals(0, p.exitValue());
}

will fail without exception (e.g. return 0):

java.lang.AssertionError: Values should be different. Actual: 0

Even though the logs state (implying the Exception is being thrown)

Error translating Commandline.

Suggested fix:

 

As the Exception is thrown in the constructor, it can be difficult to catch it, so I suggest throwing it up to the process runner (executeCommandLineAsCallable) can handle it appropriately.
However, I'm unsure of the implications.

Issue Links

• links to: GitHub Pull Request #5