[MSHARED-655] ArtifactInstaller check for integrity of parameters null, empty collection, being a directory

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: maven-artifact-transfer-0.9.1
• Fix Version/s: maven-artifact-transfer-0.10.0
• Component/s: maven-artifact-transfer
• Assignee: Karl Heinz Marbaise
• Reporter: Karl Heinz Marbaise
• Created: 20/Aug/17 10:18
• Updated: 28/Jan/18 19:53
• Resolved: 28/Jan/18 19:53

Description

Currently the interface ArtifactInstaller contains the two methods:

public interface ArtifactInstaller
{
    void install( ProjectBuildingRequest request, Collection<Artifact> mavenArtifacts );
    void install( ProjectBuildingRequest request, File localRepository, Collection<Artifact> mavenArtifacts );
}

We should make sure that ProjectBuildRequest can't be null. Furthermore the mavenArtifacts should also being checked for null. We need to think if an empty collection is allowed or not? (I think it should not being allowed?)
Apart from that the localRepository should be checked for null and it should be checked for being a directory if it is not null