[MSHARED-610] PrettyPrintXMLWriter internally uses java.io.PrintWriter without checking for any errors.

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: maven-shared-utils-3.2.0
• Assignee: Christian Schulte
• Reporter: Christian Schulte
• Created: 08/Jan/17 03:26
• Updated: 08/Jan/17 04:53
• Resolved: 08/Jan/17 04:13

Description

org.apache.maven.shared.utils.xml.PrettyPrintXMLWriter internally uses a java.io.PrintWriter. That class is catching all IOException s internally and does not propagate any exception itseld. Instead the checkError method is provided to check for any error during performing IO. The PrettyPrintXMLWriter must not silently ingore any exception during writing and either needs to provide a checkError method itself (to follow a bad idea) or should be updated to check for any IO errors and throw an exception.