[MSHARED-596] Support for getting local metadata for RepositoryManager

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: maven-artifact-transfer-0.9.0
• Component/s: maven-artifact-transfer
• Assignee: Guillaume Boué
• Reporter: Guillaume Boué
• Created: 15/Oct/16 20:42
• Updated: 30/Oct/16 16:15
• Resolved: 30/Oct/16 16:15

Description

The current RepositoryManager can only get the path to local artifacts, and not local metadata. The patch attached adds this support, with a new getPathForLocalMetadata method.

This method delegates to the Maven 3.0 or Maven 3.1 implementation using Sonatype Aether or Eclipse Aether accordingly. In the special case of ProjectArtifactMetadata, which isn't a metadata in Aether, this method calls "getPathForLocalArtifact" by giving it the coordinate of the POM artifact.

I tested this with Maven 3.0.5, 3.3.9 and latest 3.4.0-SNAPSHOT, and it behaves correctly. Can I have a review of this patch? This addition would allow to simplify the current DefaultProjectInstaller, by having a single point of entry through the RepositoryManager to set the local repository.

Also, is there a replacement for the deprecated ArtifactMetadata? Thanks.