[MSHARED-417] Infinite loop when loading self-referencing properties

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: maven-filtering-1.3
• Fix Version/s: maven-filtering-3.2.0
• Component/s: maven-filtering
• Environment: Maven 3.2.5. Maven-filtering-1.3.
• Assignee: Michael Osipov
• Reporter: Paul Milliken
• Created: 03/Jun/15 13:32
• Updated: 23/Jul/23 05:57
• Resolved: 14/Apr/17 21:50

Description

I've recently encountered a situation in which maven-resources-plugin would hang indefinitely when using resource filtering. I've managed to track it down to the loadPropertyFile and getPropertyValue methods in PropertyUtils.

getPropertyValue appears to have some protection against a property referring to itself. So, the following properties file loads fine:

test=${test}
test2=${test2}

With the value of the "test" property ending up as "${test}". However, if you load the following properties file:

test=${test2}
test2=${test2}

then getPropertyValue seems to get stuck in a loop attempting to resolve the property.

In our case, this was encountered as a result of a misconfiguration (our filters.properties is being generated based on a number of sources, and something was configured incorrectly). Causing the Maven process to hang indefinitely (while using 100% of a CPU core) isn't ideal behaviour.

I have reproduced this in isolation by directly invoking PropertyUtils.loadPropertyFile(File, null) with the the above data as the input file.

Issue Links

• is related to: MSHARED-1290 PropertyUtils cycle detection results in false positives
• links to: GitHub Pull Request #17