[MSHARED-1364] AbstractMavenReportRenderer should not depend on Doxia impl classes

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: maven-reporting-impl-4.0.0-M13
• Component/s: maven-reporting-impl
• Assignee: Unassigned
• Reporter: Konrad Windszus
• Created: 15/Mar/24 16:53
• Updated: 16/Mar/24 19:07

Description

The classes in package o.a.m.doxia.sink.impl should by definition not be considered stable API (and therefore only consumed from Doxia classes internally).
However https://github.com/apache/maven-reporting-impl/blob/72181306bb0e12eed50c4ba4aec98dd76499df39/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java#L47 depends on some internal constants.
This is dangerous, as those constants were removed in the context of DOXIA-685. Although constants are inlined during compile time, the evaluation of those constants vanished as well, so using them has no longer any effect. Reporting Impl should only rely on stable Doxia API to achieve a better decoupling.