[MSHARED-1300] Order of dependencies is not always retained when filtering

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: maven-common-artifact-filters-3.4.0
• Component/s: maven-common-artifact-filters
• Assignee: Elliotte Rusty Harold
• Reporter: Kamil Jarosz
• Created: 12/Sep/23 09:06
• Updated: 23/Nov/23 01:05
• Resolved: 12/Sep/23 12:10

Description

AbstractArtifactFeatureFilter does not retain the order of dependencies when filtering using multiple includes. The dependencies will be ordered first by their respective includes.

For instance when filtering the following set of dependencies using org.apache.maven.shared.artifact.filter.collection.TypeFilter

com.example:dependency-a:jar:1.0
com.example:dependency-b:war:1.0
com.example:dependency-c:zip:1.0

with includes zip,jar and excludes war, I will get the following:

com.example:dependency-c:zip:1.0
com.example:dependency-a:jar:1.0

where dependencies are ordered by their type according to the the includes. I would expect that the filter retains the original order of dependencies, irrespective of the order of includes, i.e.

com.example:dependency-a:jar:1.0
com.example:dependency-c:zip:1.0

This is caused by an invalid order of loops in org.apache.maven.shared.artifact.filter.collection.AbstractArtifactFeatureFilter#filterIncludes, where includes are traversed first instead of artifacts.

Issue Links

• links to: GitHub Pull Request #33