[MSHARED-1122] FileUtils: avoid getCanonicalPath()

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: maven-shared-utils-3.4.0, maven-shared-utils-3.4.1
• Component/s: maven-shared-utils
• Environment: Windows
• Assignee: Slawomir Jaranowski
• Reporter: Jörg Kubitz
• Created: 22/Aug/22 16:20
• Updated: 30/Apr/23 20:14
• Resolved: 13/Sep/22 05:33

Description

On JDK 11 the result has been cached with in JVM.
Since JDK 12 the result is not cached anymore by default (See https://bugs.openjdk.java.net/browse/JDK-8207005) and now very slow on windows.

For org.apache.maven.shared.utils.io.FileUtils.copyFile(File, File)
please use java.nio.file.Files.isSameFile(Path, Path) instead.

note: it's needed to call file.exists() before using Files.isSameFile() or catch NoSuchFileException 

@see

https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/180308/10/bundles/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/local/LocalFile.java

for a similar fix.

Here is a screenshot of sampling eclipse showing getCanonicalPath() as a hotspot:

Issue Links

• links to: GitHub Pull Request #114