[MSHADE-467] Dependency-reduced POM with missing exclusions in concurrent build

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.1, 3.5.0, 3.5.1
• Fix Version/s: 3.5.2
• Assignee: Romain Manni-Bucau
• Reporter: Alexander Kriegisch
• Created: 20/Jan/24 05:01
• Updated: 31/Jan/24 06:49
• Resolved: 31/Jan/24 06:49

Description

As discussed in this maven-users thread, when running Maven builds for this reproducer concurrently, some dependency exclusions are missing from the generated dependency-reduced POMs. Run the reproducer like this:

$ mvn clean package -T 4 | grep 'BUILD SUCCESS' && find . -name "dependency-reduced-pom.xml" -exec bash -c 'cat $0 | grep exclu | wc -l ' {} \;
[INFO] BUILD SUCCESS
12
12
12
12

When running with -T 1, however, the correct result is 20.

This concurrency issue might have been introduced by the MSHADE-413 fix, but I am not sure.

I have a local fix, synchronising on the injected mojo parameter MavenSession session in the lower section of ShadeMojo::rewriteDependencyReducedPomIfWeHaveReduction. There might be a better way to fix the problem, but I it leave that up to the PR reviewers to come up with one, if any.

Issue Links

• links to: GitHub Pull Request #210