[MSHADE-428] Typo causes mysterious NPE in build

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.6.0
• Assignee: Tamas Cservenak
• Reporter: Tamas Cservenak
• Created: 14/Oct/22 10:24
• Updated: 28/May/24 12:25
• Resolved: 28/May/24 12:25

Description

All versions are affected. 

Has this config for plugin:

              <transformers>
                <transformer implementation="org.apache.maven.plugins.shade.resource.ComponentsXmlResourceTransformer" />
                <transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer" />
                <transformer implementatioh="org.apache.maven.plugins.shade.resource.SisuIndexResourceTransformer" />
                <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
                  <manifestEntries>
                    <Main-Class>org.apache.maven.index.cli.NexusIndexerCli</Main-Class>
                    <Multi-Release>true</Multi-Release>
                  </manifestEntries>
                </transformer>
              </transformers> 

And build was failing with 

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.4.0:shade (default) on project indexer-cli: Error creating shaded jar: Problem shading JAR /home/cstamas/Worx/apache-maven/maven-indexer/indexer-cli/target/indexer-cli-7.0.0-SNAPSHOT.jar entry META-INF/sisu/javax.inject.Named: java.lang.NullPointerException -> [Help 1] 

Cause: there is a typo in config, notive implementatioH for sisu transformer.

This caused that list of transformes had a null element, and seems there is no validation that transformers list may not have null element. NPE happened when default shared method private boolean resourceTransformed( stepped onto null element and had null.canTransformResource( name ).

Issue Links

• links to: GitHub Pull Request #229