[MSHADE-291] shadedPattern applied multiples times when relocating the contents of META-INF/services files

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.1, 3.2.0, 3.2.1
• Fix Version/s: 3.2.2
• Labels: up-for-grabs
• Assignee: Robert Scholte
• Reporter: Jan Luehe
• Created: 18/Jun/18 14:38
• Updated: 24/May/20 22:56
• Resolved: 11/Nov/18 10:37

Description

Steps to reproduce:

1. Modified the test case for https://issues.apache.org/jira/browse/MSHADE-190, as follows:

diff --git a/pom.xml b/pom.xml
index 746b700..aea9abb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -68,12 +68,12 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-shade-plugin</artifactId>
-                <version>2.4</version>
+                <version>3.1.1</version>
                 <configuration>
                     <relocations>
                         <relocation>
-                            <pattern>org.eclipse.*</pattern>
-                            <shadedPattern>borg.eclipse.*</shadedPattern>
+                            <pattern>org.eclipse</pattern>
+                            <shadedPattern>org.eclipse1234</shadedPattern>
                         </relocation>
                     </relocations>
                     <transformers>

2. mvn package
3. jar -xvf target/shade-meta-tc-1.0-SNAPSHOT.jar META-INF/services
4. cat META-INF/services/org.osgi.framework.launch.FrameworkFactory

The shaded service implementation class looks as follows:

org.eclipse12341234.osgi.launch.EquinoxFactory

It appears that shadedPattern was applied twice.

Issue Links

• is duplicated by: MSHADE-312 META-INF/services incorrectly adjusted when relocation pattern occurs twice in package name
• links to: GitHub Pull Request #9