Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.3
    • Fix Version/s: 3.0.0
    • Labels:
      None

      Description

      Currently Groovy uses a specific format for its extension modules located under the name META-INF/services/org.codehaus.groovy.runtime.ExtensionModule .

      The content is actually a property file with 4 entries:

      • moduleName
      • moduleVersion
      • extensionClasses : a comma separated list of class names
      • staticExtensionClasses : :a comma separated list of class names

      A correct merge operation should merge the list extensionClasses and staticExtensionClasses

      Such merge operation can be implemented as a resource transformer. It not require any of a specific Groovy class and can operate on plain property files.

      I am willing to contribute this with tests as a resource transformer. In fact I already have an working implementation (quite trivial).

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user vietj opened a pull request:

          https://github.com/apache/maven-plugins/pull/96

          Groovy extension module transformer

          https://issues.apache.org/jira/browse/MSHADE-241

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/vietj/maven-plugins trunk

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/maven-plugins/pull/96.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #96


          commit 27d5fe6adc4fb56ea65d619b35b59d3367072d0a
          Author: Julien Viet <julien@julienviet.com>
          Date: 2016-11-25T16:18:49Z

          Groovy transformer for Maven Shade Plugin

          commit f0b667d5296792a2a1a6c163eac97dfbea950fa0
          Author: Julien Viet <julien@julienviet.com>
          Date: 2016-11-26T08:51:51Z

          Update test author to myself


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user vietj opened a pull request: https://github.com/apache/maven-plugins/pull/96 Groovy extension module transformer https://issues.apache.org/jira/browse/MSHADE-241 You can merge this pull request into a Git repository by running: $ git pull https://github.com/vietj/maven-plugins trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-plugins/pull/96.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #96 commit 27d5fe6adc4fb56ea65d619b35b59d3367072d0a Author: Julien Viet <julien@julienviet.com> Date: 2016-11-25T16:18:49Z Groovy transformer for Maven Shade Plugin commit f0b667d5296792a2a1a6c163eac97dfbea950fa0 Author: Julien Viet <julien@julienviet.com> Date: 2016-11-26T08:51:51Z Update test author to myself
          Hide
          olamy Olivier Lamy (*$^¨%`£) added a comment -

          pr merged.

          Show
          olamy Olivier Lamy (*$^¨%`£) added a comment - pr merged.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vietj closed the pull request at:

          https://github.com/apache/maven-plugins/pull/96

          Show
          githubbot ASF GitHub Bot added a comment - Github user vietj closed the pull request at: https://github.com/apache/maven-plugins/pull/96

            People

            • Assignee:
              olamy Olivier Lamy (*$^¨%`£)
              Reporter:
              jviet Julien Viet
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development