Uploaded image for project: 'Maven Shade Plugin'
  1. Maven Shade Plugin
  2. MSHADE-232

Introduce ResourceBundleAppendingTransformer

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.3
    • Fix Version/s: 3.0.0
    • Labels:
      None

      Description

      AppendingTransformer should support wildcards in resource elements.

      Currently it is necessary to add

      <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
          <resource>ValidationMessages.properties</resource>
      </transformer>
      <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
          <resource>ValidationMessages_en.properties</resource>
      </transformer>
      <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
          <resource>ValidationMessages_de.properties</resource>
      </transformer>

      and so on to join messages from different dependencies.

      In this case it should be sufficient to specify a single AppendingTransformer having

      <resource>ValidationMessages*.properties</resource>

      but that should not match ValidationMessagesFoo/Bar.properties (maybe <resource>ValidationMessages**.properties</resource> would).

      Alternatively a way to specify regular expressions would also work.

        Activity

        Hide
        rfscholte Robert Scholte added a comment -

        I think that ResourceBundles are a special case and deserve a separate AppendingTransformer ( just like XmlAppendingTransformer )

        Show
        rfscholte Robert Scholte added a comment - I think that ResourceBundles are a special case and deserve a separate AppendingTransformer ( just like XmlAppendingTransformer )
        Hide
        rfscholte Robert Scholte added a comment -

        Fixed in 1779329 by introducing ResourceBundleAppendingTransformer

        Show
        rfscholte Robert Scholte added a comment - Fixed in 1779329 by introducing ResourceBundleAppendingTransformer
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build maven-plugins #8583 (See https://builds.apache.org/job/maven-plugins/8583/)
        MSHADE-232 Introduce ResourceBundleAppendingTransformer (rfscholte: http://svn.apache.org/viewvc/?view=rev&rev=1779329)

        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/invoker.properties
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/one
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/one/pom.xml
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/one/src
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/one/src/main
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/one/src/main/resources
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/one/src/main/resources/org
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/one/src/main/resources/org/apache
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/one/src/main/resources/org/apache/maven
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/one/src/main/resources/org/apache/maven/plugins
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/one/src/main/resources/org/apache/maven/plugins/shade
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/one/src/main/resources/org/apache/maven/plugins/shade/its
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/one/src/main/resources/org/apache/maven/plugins/shade/its/Message.properties
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/one/src/main/resources/org/apache/maven/plugins/shade/its/Message_nl.properties
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/pom.xml
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/two
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/two/pom.xml
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/two/src
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/two/src/main
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/two/src/main/resources
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/two/src/main/resources/org
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/two/src/main/resources/org/apache
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/two/src/main/resources/org/apache/maven
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/two/src/main/resources/org/apache/maven/plugins
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/two/src/main/resources/org/apache/maven/plugins/shade
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/two/src/main/resources/org/apache/maven/plugins/shade/its
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/two/src/main/resources/org/apache/maven/plugins/shade/its/Message.properties
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/two/src/main/resources/org/apache/maven/plugins/shade/its/Message_nl.properties
        • (add) maven-shade-plugin/src/it/MSHADE-232_ResourceBundleAppendingTransformer/verify.groovy
        • (add) maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/resource/ResourceBundleAppendingTransformer.java
        • (edit) maven-shade-plugin/src/site/apt/examples/resource-transformers.apt.vm
        • (add) maven-shade-plugin/src/test/java/org/apache/maven/plugins/shade/resource/ResourceBundleAppendingTransformerTest.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #8583 (See https://builds.apache.org/job/maven-plugins/8583/ ) MSHADE-232 Introduce ResourceBundleAppendingTransformer (rfscholte: http://svn.apache.org/viewvc/?view=rev&rev=1779329 ) (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/invoker.properties (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/one (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/one/pom.xml (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/one/src (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/one/src/main (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/one/src/main/resources (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/one/src/main/resources/org (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/one/src/main/resources/org/apache (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/one/src/main/resources/org/apache/maven (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/one/src/main/resources/org/apache/maven/plugins (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/one/src/main/resources/org/apache/maven/plugins/shade (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/one/src/main/resources/org/apache/maven/plugins/shade/its (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/one/src/main/resources/org/apache/maven/plugins/shade/its/Message.properties (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/one/src/main/resources/org/apache/maven/plugins/shade/its/Message_nl.properties (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/pom.xml (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/two (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/two/pom.xml (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/two/src (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/two/src/main (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/two/src/main/resources (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/two/src/main/resources/org (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/two/src/main/resources/org/apache (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/two/src/main/resources/org/apache/maven (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/two/src/main/resources/org/apache/maven/plugins (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/two/src/main/resources/org/apache/maven/plugins/shade (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/two/src/main/resources/org/apache/maven/plugins/shade/its (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/two/src/main/resources/org/apache/maven/plugins/shade/its/Message.properties (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/two/src/main/resources/org/apache/maven/plugins/shade/its/Message_nl.properties (add) maven-shade-plugin/src/it/ MSHADE-232 _ResourceBundleAppendingTransformer/verify.groovy (add) maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/resource/ResourceBundleAppendingTransformer.java (edit) maven-shade-plugin/src/site/apt/examples/resource-transformers.apt.vm (add) maven-shade-plugin/src/test/java/org/apache/maven/plugins/shade/resource/ResourceBundleAppendingTransformerTest.java

          People

          • Assignee:
            rfscholte Robert Scholte
            Reporter:
            striderapache dennis lucero
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development