Uploaded image for project: 'MRUnit'
  1. MRUnit
  2. MRUNIT-74

Matching output but at incorrect position is not returned as an Error in the message string thrown in the RuntimeException

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: 0.8.1
        • Fix Version/s: 0.9.0
        • Labels:
          None

          Description

          It seems strange to me to not return "0 Error(s): ()" in the now RuntimeException but soon to be AssertionError when the output is correctly matched but in the incorrect order

            Activity

            Hide
            Permalink
            jdonofrio Jim Donofrio added a comment -

            Edited lookupExpectedValue to also take a List<String> errors in order to add the logged errors relating to "Received unexpected output" and "Matched expected output but at incorrect position" to the exception message

            Also corresponding with MRUNIT-48 throw more meaningful error for Received unexpected output when key, value actual class doesnt match any of the expected classes under the assumption that only one concrete class (no subclasses) is used for the key and one class for the value.

            Updated tests to pass based on the exception message changing

            committed in 1299567

            Show
            jdonofrio Jim Donofrio added a comment - Edited lookupExpectedValue to also take a List<String> errors in order to add the logged errors relating to "Received unexpected output" and "Matched expected output but at incorrect position" to the exception message Also corresponding with MRUNIT-48 throw more meaningful error for Received unexpected output when key, value actual class doesnt match any of the expected classes under the assumption that only one concrete class (no subclasses) is used for the key and one class for the value. Updated tests to pass based on the exception message changing committed in 1299567

              People

              • Assignee:
                jdonofrio Jim Donofrio
                Reporter:
                jdonofrio Jim Donofrio
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development