[MRM-1858] Javascript error when no archiva_login cookie present

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.1.0
• Fix Version/s: 2.1.1
• Component/s: browser
• Environment: linux / debian / chrome / ie
• Assignee: Olivier Lamy
• Reporter: Derek Bodin
• Created: 03/Sep/14 08:09
• Updated: 03/Sep/14 18:46
• Resolved: 03/Sep/14 18:45

Description

When the archiva_login cookie is not present the method to retrieve the user session fails with a javascript error. This causes the main page to not load correctly.

Adding the snippet below fixes the issue - but probably doesn't conform to your style guidelines.

js/archiva/main.js:68

    if(!cookieContent) return null;

The underlying problem is that cookieContent is undefined and the call to

$.parseJSON(cookieContent);

requires valid JSON.

http://api.jquery.com/jquery.parsejson/
Prior to jQuery 1.9, $.parseJSON returned null instead of throwing an error if it was passed an empty string, null, or undefined, even though those are not valid JSON.

Issue Links

• duplicates: MRM-1855 "Loading" button never disappears when no one is logged in in some browsers