Uploaded image for project: 'Maven Resolver'
  1. Maven Resolver
  2. MRESOLVER-457

Revert MRESOLVER-446

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0-alpha-6, 2.0.0
    • Resolver
    • None

    Description

      Revert MRESOLVER-446 as it is not needed. Supplier (and Maven) can customize as all places where VersionScheme needed, is client injected/set (like on request or so).

      Moreover, in Resolver 2 one needs to construct RepoSystem (DI complete component graph) -> to create session -> that can be used with selector to select VersionScheme -> that in turn is NEEDED in component graph. This is a cycle as this.

      With selector this was somewhat solved, but there are components that have no access to RepoSysSession... and those are the problem. IF all Sisu components would have access to RepoSysSession, this cycle could be broken easily.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            cstamas Tamas Cservenak
            cstamas Tamas Cservenak
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment