Uploaded image for project: 'Maven Resolver'
  1. Maven Resolver
  2. MRESOLVER-371

Unjustified WARNING log added by MRESOLVER-364

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.9.11
    • 1.9.12
    • Resolver
    • None

    Description

      The MRESOLVER-364 returned locking (to make resolver not fight over with maven-compat), but the code contains an unjustified WARN emitted when local repo is empty.
      The WARNING is ugly, but otherwise harmless.

      The warning is not needed.
      Old code: https://github.com/apache/maven-resolver/commit/fcb6be59c5a5855573886b09c70dab80074a1d27#diff-5957e1d4f9b8c4608b455583357f57f67e8904b3fb18d5d7c6b030dc33533af3L179-L196
      New code re-added: https://github.com/apache/maven-resolver/pull/295/files#diff-20bf29fc84cbd13fc224fadf4458f7c96aaad438ad9e44ccac5fc4150a729a7fR121-R133

      Example of similar code in Maven4: https://github.com/apache/maven/blob/master/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L1621-L1627
      Proposed solution: either just remove WARN, or make the whole method as in Maven4 (w/ addition of string.intern). Or, seek some other way to provide mutex?

      Attachments

        Issue Links

          Activity

            People

              cstamas Tamas Cservenak
              cstamas Tamas Cservenak
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: