Uploaded image for project: 'Maven Resolver'
  1. Maven Resolver
  2. MRESOLVER-352

Duplicate METADATA_DOWNLOADING event is being sent

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 1.9.8
    • 1.9.9
    • Resolver
    • None
    • Maven 3.9.2-SANPSHOT, Maven 4.0.0-SNAPSHOT, linux, windows, macos

    Description

      When using Maven 3.9.2-SNAPSHOT and Maven 4.0.0-SNAPSHOT we've noticed that the METADATA_DOWNLOADING event is being sent twice for the same metadata file + repository pair. And there is only one METADATA_DOWNLOADED event that corresponds to the second METADATA_DOWNLOADING event. The duplicated event might break event consumers that try to track downloads using METADATA_DOWNLOADING/METADATA_DOWNLOADED event pairs.

      The regression was introduced in this PR https://github.com/apache/maven-resolver/commit/4c5e9ea98f8815c6df8bf26baa9032c8d9cd5f2d. When the lock "upgrade" is happening there is a second pass through the resolution logic that leads to the duplicate event.

      Attachments

        Issue Links

          is caused by

          Improvement - An improvement or enhancement to an existing feature or task. MRESOLVER-346 Too eager locking

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #280

          Activity

            People

              cstamas Tamas Cservenak
              avenderov Alexey Venderov
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: