Uploaded image for project: 'Maven Resolver'
  1. Maven Resolver
  2. MRESOLVER-339

Preemptive Auth broken when default ports used

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.9.6
    • 1.9.7
    • Resolver
    • None

    Description

      The feature implemented in MRESOLVER-315 is broken when default HTTP or HTTPS ports (80 or 443 respectively) are used, as in majority of public servers.

      The SharingAuthCache "converts" the HttpHost to port-normalized one, but the code to activate preemptive tampers directly with shared state (not AuthCache), hence in these cases, it is not activated properly due key mismatch. Ironically, as UT does test this feature but are unable to open ports 80 or 443, the feature works ok.

      Fix: migrate to HttpClient 4.3+ HttpClientContext that has type safe setters/getters exposed, and HttpTransport should do things "by the book" (use authCache) that underlying implementation them sorts out proper keying.

      Attachments

        Activity

          People

            cstamas Tamas Cservenak
            cstamas Tamas Cservenak
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: